[Minor] Use <sup> tag for help icon in web UI page header #3659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @aarondav, who suggested the |
|
The new left-hand side gradient is a bit much, but otherwise this LGTM. |
|
Test build #24295 has started for PR 3659 at commit
|
|
Yeah, I got lazy while grabbing screencaps. |
|
Test build #24295 has finished for PR 3659 at commit
|
|
Test PASSed. |
|
I'm merging this into |
asfgit
pushed a commit
that referenced
this pull request
Dec 10, 2014
This small commit makes the `(?)` web UI help link into a superscript, which should address feedback that the current design makes it look like an error occurred or like information is missing. Before:  After:  Author: Josh Rosen <joshrosen@databricks.com> Closes #3659 from JoshRosen/webui-help-sup and squashes the following commits: bd72899 [Josh Rosen] Use <sup> tag for help icon in web UI page header. (cherry picked from commit f79c1cf) Signed-off-by: Josh Rosen <joshrosen@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small commit makes the
(?)web UI help link into a superscript, which should address feedback that the current design makes it look like an error occurred or like information is missing.Before:
After: